Attention is currently required from: dexter, laforge, neels. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-mgw/+/35152?usp=email )
Change subject: mgcp-client: Transmit remote IP addr in CRCX if known and port=0 ...................................................................... Patch Set 6: (4 comments) File src/libosmo-mgcp-client/mgcp_client.c: https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/f9204822_a3737a43 PS3, Line 1317: ip > it's the other way around, this function should not be freeing msg, it's > freed by the caller. Done https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/657b0539_29f2fd1f PS3, Line 1323: urn - > I mean: not return -EINVAL, instead skip the PRINTF("c=IN"). […] What you are proposing is imho even more complex to understand and handle, and changing the existing behavior. The current approach is simple and expectable imho: If the caller has an IP address and wants to share it, it will set the appropriate existing flag to say so. If the code filling in the mgcp message finds out it needs to fill in the address but it finds it cannot, then it returns an error to the caller because clearly something is unexpected and wrong at the caller. https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/c4720995_7e087348 PS3, Line 1367: * > Ack Done https://gerrit.osmocom.org/c/osmo-mgw/+/35152/comment/969fec4e_097bff4c PS3, Line 1373: * > Ack Done -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/35152?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I30165dbac5e484011d0acf46af36f105954a501d Gerrit-Change-Number: 35152 Gerrit-PatchSet: 6 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: dexter <pma...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: dexter <pma...@sysmocom.de> Gerrit-Comment-Date: Wed, 06 Dec 2023 12:00:20 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
