osmith has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ci/+/35268?usp=email )

 (

1 is the latest approved patch-set.
No files were changed between the latest approved patch-set and the submitted 
one.
 )Change subject: ansible: fix updating /opt/coverity/current
......................................................................

ansible: fix updating /opt/coverity/current

Remove the previous /opt/coverity/current symlink, before creating the
new one. Otherwise the new symlink would be created inside "current"
pointing at the old version, instead of replacing "current" with the
new symlink.

  # ln -svf /opt/coverity/2023.6.2/* /opt/coverity/current
  '/opt/coverity/current/cov-analysis-linux64-2023.6.2' -> 
'/opt/coverity/2023.6.2/cov-analysis-linux64-2023.6.2'
  # readlink /opt/covervity/current
  /opt/coverity/2022.06/cov-analysis-linux64-2022.6.0

Add the verbosity flag to the command while at it.

(The glob is unrelated, why it is needed is described in
 I2b96d1e47f2697706a042937b2852f0fc5032a7b)

Related: SYS#6685
Change-Id: I4ecb4997829b3cc61c839d089bda44f821ca8b85
---
M ansible/roles/install-coverity/tasks/main.yml
1 file changed, 26 insertions(+), 1 deletion(-)

Approvals:
  fixeria: Looks good to me, approved
  pespin: Looks good to me, but someone else must approve
  osmith: Verified




diff --git a/ansible/roles/install-coverity/tasks/main.yml 
b/ansible/roles/install-coverity/tasks/main.yml
index 246fa36..ca4a24c 100644
--- a/ansible/roles/install-coverity/tasks/main.yml
+++ b/ansible/roles/install-coverity/tasks/main.yml
@@ -37,7 +37,7 @@
       when: coverity_copy.failed == False

     - name: create link /opt/coverity/current
-      shell: ln -sf /opt/coverity/{{ coverity_version }}/* 
/opt/coverity/current
+      shell: rm -vf /opt/coverity/current && ln -svf /opt/coverity/{{ 
coverity_version }}/* /opt/coverity/current
       args:
         warn: false
       when: coverity_copy.failed == False

--
To view, visit https://gerrit.osmocom.org/c/osmo-ci/+/35268?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ci
Gerrit-Branch: master
Gerrit-Change-Id: I4ecb4997829b3cc61c839d089bda44f821ca8b85
Gerrit-Change-Number: 35268
Gerrit-PatchSet: 2
Gerrit-Owner: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged

Reply via email to