laforge has submitted this change. (
https://gerrit.osmocom.org/c/libosmocore/+/35290?usp=email )
Change subject: socket: Fix uninitialized mem ptr free in
osmo_sock_init2_multiaddr2()
......................................................................
socket: Fix uninitialized mem ptr free in osmo_sock_init2_multiaddr2()
The goto tag was wrong, probably due to a copy-paste mistype while
reimplementing the function.
Closes: Coverity CID#336546
Change-Id: I06b810fde7bf750fcb42d6d9e6223883e26f5f0b
---
M src/core/socket.c
1 file changed, 14 insertions(+), 1 deletion(-)
Approvals:
laforge: Looks good to me, approved
fixeria: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/src/core/socket.c b/src/core/socket.c
index c600732..5b7489d 100644
--- a/src/core/socket.c
+++ b/src/core/socket.c
@@ -905,7 +905,7 @@
if (family == AF_INET && loc_has_v6only_addr) {
LOGP(DLGLOBAL, LOGL_ERROR, "Cannot bind an IPv6 address
to an AF_INET socket\n");
rc = -EINVAL;
- goto ret_freeaddrinfo;
+ goto ret_freeaddrinfo_loc;
}
}
/* figure out remote side of socket */
--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35290?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I06b810fde7bf750fcb42d6d9e6223883e26f5f0b
Gerrit-Change-Number: 35290
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-MessageType: merged
