Attention is currently required from: osmith. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email )
Change subject: pcu_l1_if: signal BTS model via PCUIF ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > This patch breaks compatibility with osmo-bts v1.7.1 (current latest tag). […] Even if we make osmo-pcu v1.4.0 compatible with osmo-bts v1.7.1 and osmo-bsc v1.11.0 by lifting the primitive size checking, this would still be pretty useless because we **need to know the BTS type** in order for dummy block generation to work properly (https://gerrit.osmocom.org/c/osmo-pcu/+/35319). I think we would have to: * tag patch releases for both osmo-bts and osmo-bsc, so that both of them would speak the PCUIFv12 and indicate a BTS type to osmo-pcu; * either drop backwards compatibility with PCUIFv < 12 (see https://cgit.osmocom.org/osmo-pcu/commit/?id=46140948d9800bca6a7b4299f08b25efc1af0fa3), or keep it compatible with v10 and v11, but carefully check that it can actually work with v10 and v12. -- To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/35318?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-pcu Gerrit-Branch: osmith/1.4.0 Gerrit-Change-Id: I48eb75f65ab54fdec41ef913e24c1f18cd4a4047 Gerrit-Change-Number: 35318 Gerrit-PatchSet: 1 Gerrit-Owner: osmith <osm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Comment-Date: Mon, 11 Dec 2023 11:46:30 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
