Attention is currently required from: fixeria, osmith.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/libosmo-sccp/+/35274?usp=email )

Change subject: vty: show cs7 instance asp: Print loc and rem addr retrieved 
from socket
......................................................................


Patch Set 2:

(2 comments)

File src/osmo_ss7_vty.c:

https://gerrit.osmocom.org/c/libosmo-sccp/+/35274/comment/8ed22aba_8713fd2a
PS2, Line 1152: Current Primary Link
> So `Current Primary Link` is not the case anymore? […]
It is added in a follow-up patch where one can print the assoc info.
In here I opted for printing more general information to identify each ASP.


https://gerrit.osmocom.org/c/libosmo-sccp/+/35274/comment/7aad8305_fe8db384
PS2, Line 1182: OSMO_SOCK_MAX_ADDRS * INET6_ADDRSTRLEN + OSMO_SOCK_MAX_ADDRS + 
2 + 6 + 1
> (put in a define somewhere? https://gerrit.osmocom. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/libosmo-sccp/+/35274?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: libosmo-sccp
Gerrit-Branch: master
Gerrit-Change-Id: I607e4c2dd37f07bf1c07c88681918184e92202ea
Gerrit-Change-Number: 35274
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-CC: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: osmith <osm...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Tue, 12 Dec 2023 15:06:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osm...@sysmocom.de>
Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to