Attention is currently required from: fixeria.

pespin has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmocom-bb/+/35577?usp=email )

Change subject: mobile: add generic signals for CC/SS/SM transactions
......................................................................


Patch Set 2:

(1 comment)

File src/host/layer23/include/osmocom/bb/common/osmocom_data.h:

https://gerrit.osmocom.org/c/osmocom-bb/+/35577/comment/d20f46c1_0deb9016
PS2, Line 45:   S_L23_CC_TRANS_ALLOC,           /* new transaction has been 
allocated */
maybe TRANS_NEW instead of alloc would be better, the fact of allocating is a 
bit too detailed imho. This match more somehow what eg. netlink socket messages 
submit.
Similarly same applies to TRANS_FREE.



--
To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/35577?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmocom-bb
Gerrit-Branch: master
Gerrit-Change-Id: Idae5da24cb517878a26cc14b2ba6976e60f0b31b
Gerrit-Change-Number: 35577
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: pespin <pes...@sysmocom.de>
Gerrit-Attention: fixeria <vyanits...@sysmocom.de>
Gerrit-Comment-Date: Wed, 17 Jan 2024 10:38:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to