Attention is currently required from: fixeria, jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35672?usp=email )
Change subject: Prevent poll() in select.c to timeout too early ...................................................................... Patch Set 1: -Code-Review (1 comment) File src/core/timer.c: https://gerrit.osmocom.org/c/libosmocore/+/35672/comment/af2fde1a_22828c3d PS1, Line 199: nearest_ms += (nearest_p->tv_usec + 999) / 1000; > Just curious: in which project did you find timers less than 1 ms? […] Ack, maybe it makes sense to round 0->1 to avoid busy polls, and let the others X.Y ->X.0. Anyway the system will already add some extra time when processing, so let's not add more time ourselves here. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35672?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I79de77c79af4d50d1eb9ca0c5417123ff760dca3 Gerrit-Change-Number: 35672 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Wed, 24 Jan 2024 19:59:31 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Gerrit-MessageType: comment
