Attention is currently required from: laforge, neels, osmith, pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-msc/+/35872?usp=email )
Change subject: pick up all *.vty in EXTRA_DIST ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > For the record, 'make dist' in osmo-bsc includes all *.vty files as expected, > so the wildcard Works For Me (TM)... Personally, I am not strictly against using the wildcards. But as the above-mentioned document states, there can be problems with portability. And there will likely be warnings about that when running `autoreconf -fi`. If portability is not a concern for us (I guess it's not, since we're primarily targeting GNU/Linux nowadays?), then let's use them. The wildcards play well with the drop-in concept of the VTY test scripts. -- To view, visit https://gerrit.osmocom.org/c/osmo-msc/+/35872?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-msc Gerrit-Branch: master Gerrit-Change-Id: Id28e020fc59b83d1b4cd0e5b72314a46bea62259 Gerrit-Change-Number: 35872 Gerrit-PatchSet: 1 Gerrit-Owner: neels <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <[email protected]> Gerrit-Reviewer: laforge <[email protected]> Gerrit-Reviewer: osmith <[email protected]> Gerrit-CC: pespin <[email protected]> Gerrit-Attention: osmith <[email protected]> Gerrit-Attention: neels <[email protected]> Gerrit-Attention: laforge <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Comment-Date: Fri, 09 Feb 2024 15:42:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <[email protected]> Comment-In-Reply-To: laforge <[email protected]> Comment-In-Reply-To: fixeria <[email protected]> Comment-In-Reply-To: pespin <[email protected]> Gerrit-MessageType: comment
