Attention is currently required from: daniel, laforge, pespin. jolly has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/35982?usp=email )
Change subject: osmo_io_uring: Detach msghdr from iofd before calling iofd_handle_send_completion() ...................................................................... Patch Set 5: (3 comments) File src/core/osmo_io_uring.c: https://gerrit.osmocom.org/c/libosmocore/+/35982/comment/26249b26_472c84e4 PS4, Line 199: * If there is pending data to sent, iofd_uring_submit_tx will attach it again. > to send Done https://gerrit.osmocom.org/c/libosmocore/+/35982/comment/1a334c36_97fe3d5a PS4, Line 201: * iofd (which in turn frees this msghdr, if still attached) and frees the msghdr, causing a double free. */ > "(which in turn frees this msghdr, if still attached) and frees the msghdr". > […] Done https://gerrit.osmocom.org/c/libosmocore/+/35982/comment/cf975e1a_03c22e8a PS4, Line 210: } > where does the second free happen? in iofd_uring_submit_tx? I rephrased it. -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/35982?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: Ia349f73de2145fa360b20dd40deb73a8ffc71f07 Gerrit-Change-Number: 35982 Gerrit-PatchSet: 5 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Thu, 22 Feb 2024 10:00:39 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
