Attention is currently required from: laforge, osmith. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email )
Change subject: Use osmocom gtplib pointing to newer version of code ...................................................................... Patch Set 3: (3 comments) File rebar.config: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/1ef0e040_5a9dbee9 PS3, Line 7: {gtplib, {git, "https://github.com/osmocom/gtplib";, {branch, "osmocom/master"}}}, > wouldn't it be better to use an exact commit instead? that way it would be > clear from git history wh […] This information is kept in rebar.lock. For now it's good keeping it like this while we are doing active development. File rebar.lock: https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/5949754d_3842b3a2 PS3, Line 30: {ref,"25ace76f98f7f931691fb02d86667062b4f2c8ad"}}, > * unrelated change […] Because it's rebar.lock and not rebar.config. If rebar.lock exists (it is generated upon built if doesn't exist), then during checkout the values in that file are used. If no rebar.lock exists, then the values from rebar.config are used. I intended to merge this change here too, since osmo_gsup was updated to also accomodate new changes required (osmo_gsup HEAD of the rebar.config branch changed). https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052/comment/180b6359_5128eefa PS3, Line 37: {git,"https://github.com/uwiger/parse_trans.git";, > unrelated change (unlike gitlab, there is no git redirect if using github > urls without . […] This appeared automatically when updating gtplib. It's newer gtplib pulling this in afaict. -- To view, visit https://gerrit.osmocom.org/c/erlang/osmo-epdg/+/36052?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: erlang/osmo-epdg Gerrit-Branch: master Gerrit-Change-Id: Iaf2e195aaeac6d1b157a4b0dd6cd3d80deaa1308 Gerrit-Change-Number: 36052 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: lynxis lazus <lyn...@fe80.eu> Gerrit-CC: osmith <osm...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Comment-Date: Fri, 23 Feb 2024 13:19:13 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: osmith <osm...@sysmocom.de> Gerrit-MessageType: comment
