Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bsc/+/36084?usp=email )
Change subject: ctrl: Add lchan show to all ctrl levels ...................................................................... Patch Set 1: (12 comments) File src/osmo-bsc/bsc_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666): https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/2c999516_794f6dee PS1, Line 848: if (!strlen(bts_dump)) { braces {} are not necessary for single statement blocks File src/osmo-bsc/bts_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666): https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/736e9b6d_36f243f4 PS1, Line 1490: if (!dump) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666): https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/1a09a2f6_ddf99b5c PS1, Line 1497: if (!trx_dump) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666): https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/c1940d64_49523a36 PS1, Line 1500: if (!strlen(trx_dump)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666): https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/13ee2fd0_b6065d52 PS1, Line 1504: if (!dump) { braces {} are not necessary for single statement blocks File src/osmo-bsc/bts_trx_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666): https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/95a1656f_55f9a5a3 PS1, Line 107: if (!dump) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666): https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/14d12fd3_ba918595 PS1, Line 113: if (!ts_dump) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666): https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/20863877_8be44e47 PS1, Line 116: if (!strlen(ts_dump)) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666): https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/8e41ae50_bc3ebdbd PS1, Line 120: if (!dump) { braces {} are not necessary for single statement blocks File src/osmo-bsc/bts_trx_ts_ctrl.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666): https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/317405df_94726d75 PS1, Line 104: if (!dump) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666): https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/133e4a99_88f9d9cd PS1, Line 110: if (!lchan_dump) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14666): https://gerrit.osmocom.org/c/osmo-bsc/+/36084/comment/a6b83fc2_272fca44 PS1, Line 114: if (!dump) { braces {} are not necessary for single statement blocks -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/36084?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I23c1a7e6f6679e3964e359fb202ffe6781a07e8a Gerrit-Change-Number: 36084 Gerrit-PatchSet: 1 Gerrit-Owner: matanp <matan1...@gmail.com> Gerrit-CC: Jenkins Builder Gerrit-Comment-Date: Sat, 24 Feb 2024 14:40:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
