Attention is currently required from: pespin.

Jenkins Builder has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email )

Change subject: DIAMETER_Types: Generate types for 3GPP TS 29.273
......................................................................


Patch Set 2:

(36 comments)

File library/DIAMETER_Types.ttcn:

Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/e195df18_3f29a13b 
PS2, Line 2387: // Dependant applications
'Dependant' may be misspelled - perhaps 'Dependent'?


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/afe15e86_2065ecc4
PS2, Line 2399: type AVP_Grouped AAA_3GPP_Non_3GPP_User_Data
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/85d27377_9ab96daf
PS2, Line 2436: type AVP_UTF8String AAA_3GPP_ANID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/46e9d5ed_5aa134fd
PS2, Line 2440: type AVP_Grouped AAA_3GPP_Trace_Info
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/5a69ee20_0535fba7
PS2, Line 2444: type AVP_OctetString AAA_3GPP_MIP_FA_RK
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/a0d1bb65_4e31e901
PS2, Line 2448: type AVP_Unsigned32 AAA_3GPP_MIP_FA_RK_SPI
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/2bf8288f_e2e6ffa3
PS2, Line 2452: type AVP_Unsigned32 AAA_3GPP_PPR_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/f28f145d_2739a0bb
PS2, Line 2456: type AVP_Grouped AAA_3GPP_WLAN_Identifier
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/09135bb1_70da4f3d
PS2, Line 2460: type AVP_Grouped AAA_3GPP_TWAN_Access_Info
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/8078937c_78072de9
PS2, Line 2464: type AVP_Unsigned32 AAA_3GPP_Access_Authorization_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/0d820c90_c76d1a3b
PS2, Line 2468: type AVP_Unsigned32 AAA_3GPP_TWAN_Default_APN_Context_Id
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/88e61c3a_2dacc328
PS2, Line 2482: type AVP_OctetString AAA_3GPP_Full_Network_Name
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/2639f06b_bd99e3ee
PS2, Line 2486: type AVP_OctetString AAA_3GPP_Short_Network_Name
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/4333bfe2_2001736d
PS2, Line 2490: type AVP_Unsigned32 AAA_3GPP_AAA_Failure_Indication
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/c42f219f_1accb0aa
PS2, Line 2504: type AVP_Unsigned32 AAA_3GPP_DER_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/ad1011e4_434e3818
PS2, Line 2508: type AVP_Unsigned32 AAA_3GPP_DEA_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/e8d1aa3e_baa8b0f1
PS2, Line 2512: type AVP_Unsigned32 AAA_3GPP_RAR_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/48c9cf2b_d8ed1ee6
PS2, Line 2516: type AVP_Unsigned32 AAA_3GPP_DER_S6b_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/a3b808be_fd86ca5c
PS2, Line 2520: type AVP_UTF8String AAA_3GPP_SSID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/6ed15b6d_21d67d0d
PS2, Line 2524: type AVP_UTF8String AAA_3GPP_HESSID
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/630e87b2_fa0e935f
PS2, Line 2529: type AVP_Grouped AAA_3GPP_Access_Network_Info
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/c67d80d2_f5f535e9
PS2, Line 2533: type AVP_Unsigned32 AAA_3GPP_TWAN_Connection_Mode
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/03997e2e_0e580a29
PS2, Line 2537: type AVP_Grouped AAA_3GPP_TWAN_Connectivity_Parameters
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/3f2be7ab_26c415a5
PS2, Line 2541: type AVP_Unsigned32 AAA_3GPP_Connectivity_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/db5314ec_8a088dac
PS2, Line 2545: type AVP_Grouped AAA_3GPP_TWAN_PCO
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/cc7b00b5_76301451
PS2, Line 2549: type AVP_Address AAA_3GPP_TWAG_CP_Address
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/99357aee_dc8ac3ba
PS2, Line 2553: type AVP_UTF8String AAA_3GPP_TWAG_UP_Address
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/4896a1cf_a827572d
PS2, Line 2557: type AVP_Unsigned32 AAA_3GPP_TWAN_S2a_Failure_Cause
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/2b4b9e98_3bca0b96
PS2, Line 2561: type AVP_Unsigned32 AAA_3GPP_SM_Back_Off_Timer
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/c75d29c7_e3efed76
PS2, Line 2565: type AVP_OctetString AAA_3GPP_WLCP_Key
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/3a13504e_4ffab1b3
PS2, Line 2569: type AVP_Unsigned64 AAA_3GPP_Origination_Time_Stamp
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/359b96ba_7a047bce
PS2, Line 2573: type AVP_Unsigned32 AAA_3GPP_Maximum_Wait_Time
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/85869b00_ffa9efe9
PS2, Line 2577: type AVP_Unsigned32 AAA_3GPP_Emergency_Services
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/f5047d85_9b9d6222
PS2, Line 2581: type AVP_Unsigned32 AAA_3GPP_AAR_Flags
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/458ae852_8e3de7fa
PS2, Line 2585: type AVP_Unsigned32 AAA_3GPP_IMEI_Check_In_VPLMN_Result
trailing whitespace


Robot Comment from checkpatch (run ID jenkins-gerrit-lint-14868):
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162/comment/7ec366e9_dd574ff1
PS2, Line 2589: type AVP_Unsigned32 AAA_3GPP_ERP_Authorization
trailing whitespace



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36162?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I17f7f025ff31d9ce619cd23bfa5f1af282969dbf
Gerrit-Change-Number: 36162
Gerrit-PatchSet: 2
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Tue, 05 Mar 2024 11:17:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment

Reply via email to