Harald Welte has submitted this change and it was merged. Change subject: hnbgw_cn: rx ranap: set rc in all cases ......................................................................
hnbgw_cn: rx ranap: set rc in all cases There don't seem to be any evaluations of the rc, nevertheless return well-defined values. Fixes: CID#181968 Change-Id: I59295388564e5d270da32db6e7488755231f8a11 --- M src/hnbgw_cn.c 1 file changed, 3 insertions(+), 0 deletions(-) Approvals: Harald Welte: Looks good to me, approved Jenkins Builder: Verified diff --git a/src/hnbgw_cn.c b/src/hnbgw_cn.c index c48f4b7..ede00c8 100644 --- a/src/hnbgw_cn.c +++ b/src/hnbgw_cn.c @@ -19,6 +19,7 @@ */ #include <arpa/inet.h> +#include <errno.h> #include <osmocom/core/msgb.h> #include <osmocom/core/utils.h> @@ -209,10 +210,12 @@ LOGP(DRANAP, LOGL_NOTICE, "Received unsupported RANAP " "unsuccessful outcome procedure %ld from CN, ignoring\n", pdu->choice.unsuccessfulOutcome.procedureCode); + rc = -ENOTSUP; break; default: LOGP(DRANAP, LOGL_NOTICE, "Received suspicious RANAP " "presence %u from CN, ignoring\n", pdu->present); + rc = -EINVAL; break; } -- To view, visit https://gerrit.osmocom.org/5806 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: merged Gerrit-Change-Id: I59295388564e5d270da32db6e7488755231f8a11 Gerrit-PatchSet: 1 Gerrit-Project: osmo-iuh Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder