Patch Set 7: Code-Review-1 (2 comments)
would be nice to split this patch https://gerrit.osmocom.org/#/c/5818/5/configure.ac File configure.ac: Line 62: AC_MSG_RESULT([$enable_sysmobts_calib]) With this patch it seems that this alone does not work: ./configure --with-sysmobts=foo and that the old invocation ./configure --enable-sysmocom-bts also no longer works on its own? I think... * we should keep the old --enable-sysmocom-bts option so we don't produce build fallout everywhere. It should yield exactly the previous behavior: * we need a $sysmobts_incdir default so that --enable-sysmocom-bts works without issuing --with-sysmobts=. * when --with-sysmobts was passed, $enable_sysmocom_bts should also be set to yes. https://gerrit.osmocom.org/#/c/5818/5/contrib/sysmobts-calib/Makefile.am File contrib/sysmobts-calib/Makefile.am: Line 2: AM_CFLAGS = -Wall $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) shouldn't this also include the sysmobts header CFLAGS? -- To view, visit https://gerrit.osmocom.org/5818 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I94ea8bad8b410550f72ee6a0408f42f6bd8b6cac Gerrit-PatchSet: 7 Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Pau Espin Pedrol <pes...@sysmocom.de> Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu> Gerrit-Reviewer: neels <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
