[PATCH] osmo-bsc[master]: handover_decision: log HO causes more accurately

[Neels Hofmeyr]

Hello Harald Welte, Jenkins Builder,

I'd like you to reexamine a change.  Please visit

    https://gerrit.osmocom.org/5802

to look at the new patch set (#3).

handover_decision: log HO causes more accurately

Tweaked-by: nhofm...@sysmocom.de
Change-Id: Ib0a0787ac8b877ac63455d72886389b546e7a337
---
M src/libbsc/handover_decision.c
1 file changed, 15 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.osmocom.org:29418/osmo-bsc refs/changes/02/5802/3

diff --git a/src/libbsc/handover_decision.c b/src/libbsc/handover_decision.c
index c637e25..3bca05f 100644
--- a/src/libbsc/handover_decision.c
+++ b/src/libbsc/handover_decision.c
@@ -230,7 +230,7 @@
        rc = handover_to_arfcn_bsic(mr->lchan, best_cell->arfcn, 
best_cell->bsic);
        switch (rc) {
        case 0:
-               LOGPC(DHO, LOGL_INFO, "Starting handover\n");
+               LOGPC(DHO, LOGL_INFO, "Starting handover: meas report number %d 
\n", mr->nr);
                break;
        case -ENOSPC:
                LOGPC(DHO, LOGL_INFO, "No channel available\n");
@@ -278,20 +278,30 @@
 
        /* Interference HO */
        if (rxlev2dbm(av_rxlev) > -85 &&
-           meas_rep_n_out_of_m_be(mr->lchan, dqual, 3, 4, 5))
+           meas_rep_n_out_of_m_be(mr->lchan, dqual, 3, 4, 5)) {
+               LOGPC(DHO, LOGL_INFO, "HO cause: Interference HO av_rxlev=%d 
dBm\n",
+                     rxlev2dbm(av_rxlev));
                return attempt_handover(mr);
+       }
 
        /* Bad Quality */
-       if (meas_rep_n_out_of_m_be(mr->lchan, dqual, 3, 4, 5))
+       if (meas_rep_n_out_of_m_be(mr->lchan, dqual, 3, 4, 5)) {
+               LOGPC(DHO, LOGL_INFO, "HO cause: Bad Quality av_rxlev=%d 
dBm\n", rxlev2dbm(av_rxlev));
                return attempt_handover(mr);
+       }
 
        /* Low Level */
-       if (rxlev2dbm(av_rxlev) <= -110)
+       if (rxlev2dbm(av_rxlev) <= -110) {
+               LOGPC(DHO, LOGL_INFO, "HO cause: Low Level av_rxlev=%d dBm\n", 
rxlev2dbm(av_rxlev));
                return attempt_handover(mr);
+       }
 
        /* Distance */
-       if (mr->ms_l1.ta > net->handover.max_distance)
+       if (mr->ms_l1.ta > net->handover.max_distance) {
+               LOGPC(DHO, LOGL_INFO, "HO cause: Distance av_rxlev=%d dBm 
ta=%u\n",
+                     rxlev2dbm(av_rxlev), mr->ms_l1.ta);
                return attempt_handover(mr);
+       }
 
        /* Power Budget AKA Better Cell */
        if ((mr->nr % net->handover.pwr_interval) == net->handover.pwr_interval 
- 1)

-- 
To view, visit https://gerrit.osmocom.org/5802
To unsubscribe, visit https://gerrit.osmocom.org/settings

Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib0a0787ac8b877ac63455d72886389b546e7a337
Gerrit-PatchSet: 3
Gerrit-Project: osmo-bsc
Gerrit-Branch: master
Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de>
Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org>
Gerrit-Reviewer: Ivan Kluchnikov <kluchnik...@gmail.com>
Gerrit-Reviewer: Jenkins Builder