Attention is currently required from: neels. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-upf/+/35667?usp=email )
Change subject: manual: explain GTP Echo workaround for tunmap ...................................................................... Patch Set 1: -Code-Review (4 comments) Patchset: PS1: > I would remove the entire "tunend can be removed for forwarding-only" > section. It's misleading. […] I'm not sure what exactly I was reading / referring to at the time. Let's ignore this comment, please. File doc/manuals/chapters/running.adoc: https://gerrit.osmocom.org/c/osmo-upf/+/35667/comment/2d7ddd38_fd25f593 PS1, Line 172: netfilter it s a nftables or nft table. "netfilter" is a set of kernel hooks in the network stack that have no tables. various packet filtering techniques (iptables, arptables, ip6tables and last nftables) are packet filter ruleset engines that have tables. https://gerrit.osmocom.org/c/osmo-upf/+/35667/comment/053a0cf7_e239e8ff PS1, Line 177: GTP peer is that "GTP peer" a term in the specification? The term I have in memory is "GSN", but that's probably too old-fashioned as it is from the 2G/3G days where we had SGSN/GGSN. I'm worried about "peer" here being interprete as "the remote peer". But we're actually talking about our local UPF node, not a remote peer. https://gerrit.osmocom.org/c/osmo-upf/+/35667/comment/44e0c63a_8208db06 PS1, Line 212: netfilter nft / nftables table -- To view, visit https://gerrit.osmocom.org/c/osmo-upf/+/35667?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-upf Gerrit-Branch: master Gerrit-Change-Id: Ic824fc876d1fad181254cb6894e51464c443b53c Gerrit-Change-Number: 35667 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Fri, 15 Mar 2024 20:25:32 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Comment-In-Reply-To: laforge <lafo...@osmocom.org> Gerrit-MessageType: comment
