Attention is currently required from: fixeria, pespin. dexter has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email )
Change subject: IPAd_Tests: add testsuite for an IPAd ...................................................................... Patch Set 2: (5 comments) File ipad/IPAd_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/731959b6_c76ed951 PS1, Line 51: function f_make_http_resp > this looks more like a `template`? Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/d776d58e_327939dc PS1, Line 104: modulepar > not critical, but we usually have module params on top Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/c9997b95_78a230f9 PS1, Line 208: while(true) > cosmetic: while is not a function (same below) Done https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/0e601fe3_fb27b29c PS1, Line 445: for (i := 0; i < sizeof(esipa_res.getBoundProfilePackageResponseEsipa.getBoundProfilePackageOkEsipa.boundProfilePackage.firstSequenceOf87); i := i + 1) { > sounds like you want to put this in a variable ;) > "esipa_res.getBoundProfilePackageResponseEsipa. […] I do not know if this looks much nicer ;-/ var RSPDefinitions.BoundProfilePackage.firstSequenceOf87 firstSequenceOf87 := esipa_res.getBoundProfilePackageResponseEsipa.getBoundProfilePackageOkEsipa.boundProfilePackage.firstSequenceOf87; https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229/comment/dd96cb3e_15c1dc14 PS1, Line 652: // execute ( TC_add_init_eim() ); > why is this one commented out? This test requires the IPAd to be called with different command line parameters and a file that contains the eIM configuration. I have used this testcase mainly as a vehicle to see what is spoken to the eUICC on the other end. The testcase does not add much value anyway, so I have removed it now. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36229?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ic9ea8c69e56a2e8ddf0f506861ece6d40cbcb06d Gerrit-Change-Number: 36229 Gerrit-PatchSet: 2 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: fixeria <vyanits...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 02 Apr 2024 15:06:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: fixeria <vyanits...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
