pespin has submitted this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36534?usp=email )

Change subject: pgw: Always expect local TEIC when receiving 
DeleteSessionResponse
......................................................................

pgw: Always expect local TEIC when receiving DeleteSessionResponse

open5gs-smfd is since recently acting properly and setting the proper
TEIC when sending GTPv2C messages for cases where session is not found.

Related: https://github.com/open5gs/open5gs/issues/3043

Change-Id: I2086b4576a10c7b4ba8217be6e49c8f5f389bc4b
---
M pgw/PGW_Tests.ttcn
1 file changed, 18 insertions(+), 5 deletions(-)

Approvals:
  fixeria: Looks good to me, approved
  Jenkins Builder: Verified
  osmith: Looks good to me, but someone else must approve




diff --git a/pgw/PGW_Tests.ttcn b/pgw/PGW_Tests.ttcn
index a1850a0..08cd1a0 100644
--- a/pgw/PGW_Tests.ttcn
+++ b/pgw/PGW_Tests.ttcn
@@ -833,7 +833,6 @@

 /* delete the session from the PGW */
 private function f_delete_session(template (omit) GTP2C_Cause tx_cause := omit,
-                                 template (present) OCT4 exp_teid,
                                  template (present) GTP2C_Cause exp_cause,
                                  boolean expect_diameter := true) runs on 
PGW_Session_CT {
        var template (value) FullyQualifiedTEID fteid_c_ie
@@ -852,7 +851,7 @@
                as_DIA_Gy_CCR(TERMINATION_REQUEST);
        }
        alt {
-       [] GTP2.receive(tr_GTP2C_DeleteSessionResp(d_teid := exp_teid, cause := 
exp_cause)) {
+       [] GTP2.receive(tr_GTP2C_DeleteSessionResp(d_teid := g_pars.teic_local, 
cause := exp_cause)) {
                setverdict(pass);
                }
        [] GTP2.receive(tr_GTP2C_DeleteSessionResp(?, ?)) {
@@ -1021,7 +1020,7 @@
 /* create a session, then delete it again */
 private function f_TC_createSession_deleteSession() runs on PGW_Session_CT {
        f_s5s8_create_session();
-       f_delete_session(omit, g_pars.teic_local, Request_accepted);
+       f_delete_session(omit, Request_accepted);
        setverdict(pass);
 }
 testcase TC_createSession_deleteSession() runs on PGW_Test_CT {
@@ -1035,7 +1034,7 @@
 /* send a DeleteSessionReq for an unknown/invalid TEID */
 private function f_TC_deleteSession_unknown() runs on PGW_Session_CT {
        g_pars.teic_remote := f_rnd_octstring(4);
-       f_delete_session(omit, '00000000'O, Context_Not_Found, false);
+       f_delete_session(omit, Context_Not_Found, false);
        setverdict(pass);
 }
 testcase TC_deleteSession_unknown() runs on PGW_Test_CT {
@@ -1066,7 +1065,7 @@
        as_DIA_Gy_CCR(UPDATE_REQUEST);
        f_validate_gy_cc_report(g_rx_gy, VALIDITY_TIME, (3..4), ?, ?);

-       f_delete_session(omit, g_pars.teic_local, Request_accepted);
+       f_delete_session(omit, Request_accepted);
        f_validate_gy_cc_report(g_rx_gy, FINAL, (0..1), 0, 0);
        setverdict(pass);
 }

--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36534?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I2086b4576a10c7b4ba8217be6e49c8f5f389bc4b
Gerrit-Change-Number: 36534
Gerrit-PatchSet: 3
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged

Reply via email to