pespin has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/36554?usp=email )
Change subject: tbf_ul.h: Mark empty param list as void
......................................................................
tbf_ul.h: Mark empty param list as void
While at it, fix wrong whitespace indentation in one of the lines.
Change-Id: I2a9213a9fdbe0f4b70d820c449dbb71539a733ce
---
M src/tbf_ul.h
1 file changed, 19 insertions(+), 8 deletions(-)
Approvals:
Jenkins Builder: Verified
fixeria: Looks good to me, approved
diff --git a/src/tbf_ul.h b/src/tbf_ul.h
index 4ec0f6f..7a4c70c 100644
--- a/src/tbf_ul.h
+++ b/src/tbf_ul.h
@@ -59,8 +59,8 @@
struct gprs_rlcmac_ul_tbf : public gprs_rlcmac_tbf {
gprs_rlcmac_ul_tbf(struct gprs_rlcmac_bts *bts, GprsMs *ms);
- ~gprs_rlcmac_ul_tbf();
- gprs_rlc_window *window();
+ ~gprs_rlcmac_ul_tbf(void);
+ gprs_rlc_window *window(void);
void apply_allocated_resources(const struct alloc_resources_res *res);
/* blocks were acked */
int rcv_data_block_acknowledged(
@@ -70,7 +70,7 @@
/* TODO: extract LLC class? */
int assemble_forward_llc(const gprs_rlc_data *data);
- int snd_ul_ud();
+ int snd_ul_ud(void);
egprs_rlc_ul_reseg_bsn_state handle_egprs_ul_spb(
const struct gprs_rlc_data_info *rlc,
@@ -87,12 +87,12 @@
struct gprs_rlc_data *block,
uint8_t *data, const uint8_t block_idx);
- uint16_t window_size() const;
- void set_window_size();
+ uint16_t window_size(void) const;
+ void set_window_size(void);
void update_coding_scheme_counter_ul(enum CodingScheme cs);
- void usf_timeout();
- void contention_resolution_start();
- void contention_resolution_success();
+ void usf_timeout(void);
+ void contention_resolution_start(void);
+ void contention_resolution_success(void);
/* Please note that all variables here will be reset when changing
* from WAIT RELEASE back to FLOW state (re-use of TBF).
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/36554?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: I2a9213a9fdbe0f4b70d820c449dbb71539a733ce
Gerrit-Change-Number: 36554
Gerrit-PatchSet: 1
Gerrit-Owner: pespin <pes...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged
