Attention is currently required from: fixeria, pespin. osmith has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email )
Change subject: pcu: Update component diagram ...................................................................... Patch Set 3: Code-Review+1 (1 comment) Patchset: PS3: The graph looks good. However, how are other developers supposed to look at it? The dot syntax from the markdown doesn't render here: https://gitea.osmocom.org/ttcn3/osmo-ttcn3-hacks/src/branch/master/pcu Maybe it makes sense to put them in separate files instead, and adding a Makefile target to generate them (similar to e.g. the message sequence charts in osmo-msc: https://gitea.osmocom.org/cellular-infrastructure/osmo-msc/src/branch/master/doc/sequence_charts)? Or maybe also include the generated svg, and show that in the README.md? -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36556?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ie592a9301b7a900334650741ed633cd70535a2b1 Gerrit-Change-Number: 36556 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 07:50:58 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment
