Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36385?usp=email )
Change subject: per-HNB GTP-U traffic counters via nft ...................................................................... Patch Set 17: (1 comment) Patchset: PS3: Pau, every so often your CR uses stylistic means of downplaying a submitted patch without a sound base for it. Wording like these come to mind: - "playing around with" belittles a technically sound implementation. - "all this foo" is too general and diffuse, CR needs to be on point. - "everything ends up broken" without anything broken being present. > Fine if you want to keep it in 2 patches, but I wouldn't merge this one until > the other one is ready and can be merged together. Kindly state your reason for this statement, it seems unqualified to me. And kindly state your reason directly at the start of a CR discussion, next time. I would appreciate that very much. I am not playing around, I know what I am doing, and decided things for sound reasons. I need you to acknowledge that. If you disagree, then let's stay with the sound arguments against it. Thanks! Also let's discuss in the proper place. CR is bringing up threading details in CR on patches without any threading. This patch here is not multi threaded. For threading, let's discuss at the patch introducing the nft thread. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36385?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I35b7e97fd039e36633dfde1317170527c82f9f68 Gerrit-Change-Number: 36385 Gerrit-PatchSet: 17 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 15 Apr 2024 15:39:55 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
