Attention is currently required from: jolly. pespin has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email )
Change subject: Do not reconnect when receiving SCTP notification ...................................................................... Patch Set 1: (1 comment) File src/stream_cli.c: https://gerrit.osmocom.org/c/libosmo-netif/+/36568/comment/137e8852_3488b14f PS1, Line 500: if (res == -EAGAIN) { The res = -EAGAIN is more like "historical reasons" imho (I wrote further support there afterwards), you should better check the flags (set in stream_sctp_recvmsg_trailer()): if (msgb_sctp_msg_flags(msg) & OSMO_STREAM_SCTP_MSG_FLAGS_NOTIFICATION) See for instance: libosmo-sccp/src/osmo_ss7_asp.c:824 or line 998. -- To view, visit https://gerrit.osmocom.org/c/libosmo-netif/+/36568?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmo-netif Gerrit-Branch: master Gerrit-Change-Id: Ic588e6d8a3eecde701778f7d6ff5599ab81eff2b Gerrit-Change-Number: 36568 Gerrit-PatchSet: 1 Gerrit-Owner: jolly <andr...@eversberg.eu> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: jolly <andr...@eversberg.eu> Gerrit-Comment-Date: Tue, 16 Apr 2024 14:17:01 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
