Attention is currently required from: osmith, pespin.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email )

Change subject: sgsn: add testcases for SGSN Context Request procedure
......................................................................


Patch Set 2:

(2 comments)

File sgsn/SGSN_Tests.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589/comment/6377ced0_fd15be8d
PS2, Line 3807:                 log("Rx SGSN Context Request from SGSN: ", 
gtpc_ud.gtpc);
> This log is most probably not needed, only polluting output.
Done


https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589/comment/b778b835_2170f575
PS2, Line 3852:                 log("Rx SGSN Context ACK from SGSN: ", 
gtpc_ud.gtpc);
> same, not needed.
Done



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36589?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: If71de10897a8a9f6612cd46c760cd89c0299ac2c
Gerrit-Change-Number: 36589
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-Attention: osmith <osm...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Fri, 19 Apr 2024 09:56:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to