fixeria has submitted this change. (
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36599?usp=email )
Change subject: library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates
......................................................................
library: GTPv1C: fix ts_MM_Context{GSM,UMTS} templates
Set the values according to 3GPP TS 29.060 version 17.4.0 Release 17.
* Field 'spare' is defined as 'Spare 1111' in Table 40 (missing '1').
* Field 'spare1' is defined as 'Spare 111' in Table 41.
* Field 'security' must be set as per Table 47.
Change-Id: Ic8abb048f7c1fa795ee472820c5b88de0073dc66
Fixes: f95460b55 "GTP_Templates: Add templates for some GTPv1C IEs"
Fixes: fdde16846 "library: GTPv1C add ts_MM_ContextGSM"
---
M library/GTPv1C_Templates.ttcn
1 file changed, 22 insertions(+), 5 deletions(-)
Approvals:
laforge: Looks good to me, approved
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
diff --git a/library/GTPv1C_Templates.ttcn b/library/GTPv1C_Templates.ttcn
index 0dc30be..e9cf797 100644
--- a/library/GTPv1C_Templates.ttcn
+++ b/library/GTPv1C_Templates.ttcn
@@ -346,10 +346,10 @@
mmcontGSM := {
lengthf := 0, /* overwritten */
cksn := cksn,
- spare := '00000'B,
+ spare := '11111'B,
usedCipher := gea,
- noofVectors := 0,
- security := '00'B, /* XXX */
+ noofVectors := 0, /* overwritten */
+ security := '01'B, /* GSM key and triplets */
kc := kc,
triplet := ''O,
drx_par := '0000'O,
@@ -372,9 +372,9 @@
usedGPRSIntegrityAlgorithm := '000'B,
ugipai := '1'B, /* Integrity Protection not
required */
gupii := '1'B, /* Ignore "Used GPRS integrity
protection algorithm" field" */
- spare1 := '000'B,
+ spare1 := '111'B,
noofVectors := 0, /* TODO: fill quintpuplets*/
- security := '01'B, /* UMTS key and quintuplets
*/
+ security := '10'B, /* UMTS key and quintuplets
*/
ck := ck,
ik := ik,
quintupletlength := 0, /* overwritten */
--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/36599?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: Ic8abb048f7c1fa795ee472820c5b88de0073dc66
Gerrit-Change-Number: 36599
Gerrit-PatchSet: 2
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged
