Attention is currently required from: neels, pespin. laforge has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36540?usp=email )
Change subject: nft_kpi: retrieve counters in a separate thread ...................................................................... Patch Set 3: (1 comment) Patchset: PS3: > Your responses on the blocking behavior still do not have empirical > substance. […] I am surprised to hear that the VTY would use blocking writes. telnet_new_connection() uses osmo_fd_register() on the accept()ed socket, which as it first step sets the Fd non-blocking. libosmovty's buffer_flush_available() at least claims to deal with non-blocking sockets. Likewise, every new CTRL file descriptor goes through osmo_fd_register() which sets O_NONBLOCK as described above. Which blocking "various syscalls" are you referring to? I would generally consider those bugs and it would be good to document those as such if you know any. The general intent was always to have no blocking syscalls, specifically no blocking I/O from osmo* programs. I know of very few exceptions (like parts of osmo-e1d) and there it is a TODO to get them fixed and there are related comments in the code. So the point is not how long nft takes [in your testing], or whether we trust you. The point is that doing anything non-blocking is - AFAICT - a grave violation of the general architecture and paradigm of how we do things in the non-blocking, asynchronous, event-driven osmo-* world. -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36540?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: I9dc54e6bc94c553f45adfa71ae8ad70be4afbc8f Gerrit-Change-Number: 36540 Gerrit-PatchSet: 3 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Sun, 21 Apr 2024 06:18:18 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: laforge <lafo...@osmocom.org> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
