Attention is currently required from: pespin. falconia has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-bts/+/36706?usp=email )
Change subject: rsl.adoc: document RSL_IE_OSMO_RTP_EXTENSIONS ...................................................................... Patch Set 1: (2 comments) File doc/manuals/abis/rsl.adoc: https://gerrit.osmocom.org/c/osmo-bts/+/36706/comment/8b58b70a_77cfacb1 PS1, Line 872: | 0x62 | RSL_IE_OSMO_TEMP_OVP_ACCH_CAP | <<RSL_IE_OSMO_TEMP_OVP_ACCH_CAP>> > These 2 above seem to actually be missing but not really related to this > patch, so perhaps submit th […] The current state of the doc covers IEIs up to 0x61, but libosmocore has definitions up to 0x63. I picked 0x64 for my new IE, but attempting to document 0x64 right after 0x61 makes it obvious that the documentation step got skipped for 0x62 and 0x63. But yes, I will split this part off into a separate pre-patch. https://gerrit.osmocom.org/c/osmo-bts/+/36706/comment/234cb521_8172cf88 PS1, Line 1110: This information element requests the use of non-standard enhanced RTP > I'm maybe missing some sort of packetdiag output (see for instance packetdiag > examples in . […] About TLV: I am open to changing this IE to TV. For context, please read TW-TS-003: https://www.freecalypso.org/specs/tw-ts-003-v010001.txt TW-TS-003 defines one new IE on AoIP BSSMAP interface, and that one is of fixed-length TV format. Now we need to propagate the same signaling from the BSC to the BTS - but for Abis-IP, unlike AoIP, there are no 3GPP specs at all, hence nothing to extend with TW-TS-* specs - instead all Abis-IP definitions have to be worked out in Osmocom only. For the Osmocom-controlled IE from OsmoBSC to OsmoBTS, my first thought was to make it TV and define it as an exact copy of TW-TS-003 on AoIP. But then I saw that all other Osmocom extension IEs, e.g., RSL_IE_OSMO_OSMUX_CID, are defined as TLV, even though Osmux CID for example is always one byte. Hence I followed suit with my new IE. Maybe we can now decide if the new IE (that replicates TW-TS-003 on Abis-IP) should be TV or TLV, and then document it accordingly? -- To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36706?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-bts Gerrit-Branch: master Gerrit-Change-Id: I6117049b17ced5fb6635ac70d9238169033af4de Gerrit-Change-Number: 36706 Gerrit-PatchSet: 1 Gerrit-Owner: falconia <fal...@freecalypso.org> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 07 May 2024 17:24:04 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
