Attention is currently required from: laforge, neels, pespin. Jenkins Builder has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email )
Change subject: per-HNB GTP-U traffic counters via nft ...................................................................... Patch Set 4: (6 comments) File src/osmo-hnbgw/hnbgw.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/27cb50fa_a1c2d0c6 PS4, Line 585: if (getpeername(fd, &osa.u.sa, &socklen)){ space required before the open brace '{' File src/osmo-hnbgw/nft_kpi.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/cfffabca_cb61ff3e PS4, Line 193: static const char *nft_thread_req_type_name[] = { static const char * array should probably be static const char * const Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/f95be9ba_bdf88f8b PS4, Line 620: while (1) { braces {} are not necessary for single statement blocks Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/d0cc942e_62412f17 PS4, Line 652: if (period_us < 1) suspect code indent for conditional statements (7, 15) Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/cfff3b06_24b62f7b PS4, Line 653: period_us = 1; code indent should use tabs where possible Robot Comment from checkpatch (run ID jenkins-gerrit-lint-16220): https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539/comment/4075a7e7_9e0e6e81 PS4, Line 653: period_us = 1; please, no spaces at the start of a line -- To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36539?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-hnbgw Gerrit-Branch: master Gerrit-Change-Id: Ib2f0a9252715ea4b2fe9c367aa65f771357768ca Gerrit-Change-Number: 36539 Gerrit-PatchSet: 4 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Tue, 21 May 2024 16:25:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Gerrit-MessageType: comment
