Attention is currently required from: neels.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-hnbgw/+/36911?usp=email )

Change subject: fix rate_ctr leak in hnb_persistent_free()
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Patchset:

PS1:
nitpick: It is likely not really a leak as hnbp->ctrs uses hnbp as talloc 
context and will be talloc_free'd due to the hierarchical nature.

It's more that the llist_del of ctrs->list doesn't happen and we're avoiding 
linked list corruption here.  So the fix is right, just commit message probably 
incorrect.



--
To view, visit https://gerrit.osmocom.org/c/osmo-hnbgw/+/36911?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-hnbgw
Gerrit-Branch: master
Gerrit-Change-Id: I14e050bfb91b993f194e3800eacdc0d10f2b1a4e
Gerrit-Change-Number: 36911
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Thu, 23 May 2024 14:36:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to