laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/36904?usp=email )
Change subject: pySim-trace.py: Resolve possible variable use before assignment ...................................................................... pySim-trace.py: Resolve possible variable use before assignment pySim-trace.py:198:27: E0606: Possibly using variable 's' before assignment (possibly-used-before-assignment) Change-Id: I28c137a20143b2cd6ea9a0d5461ab61fcd6fe935 --- M pySim-trace.py 1 file changed, 13 insertions(+), 0 deletions(-) Approvals: laforge: Looks good to me, approved Jenkins Builder: Verified diff --git a/pySim-trace.py b/pySim-trace.py index be1d40b..165e338 100755 --- a/pySim-trace.py +++ b/pySim-trace.py @@ -194,6 +194,8 @@ s = PysharkRsproLive(opts.interface) elif opts.source == 'gsmtap-pyshark-pcap': s = PysharkGsmtapPcap(opts.pcap_file) + else: + raise ValueError("unsupported source %s", opts.source) tracer = Tracer(source=s, suppress_status=opts.suppress_status, suppress_select=opts.suppress_select, show_raw_apdu=opts.show_raw_apdu) -- To view, visit https://gerrit.osmocom.org/c/pysim/+/36904?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: I28c137a20143b2cd6ea9a0d5461ab61fcd6fe935 Gerrit-Change-Number: 36904 Gerrit-PatchSet: 1 Gerrit-Owner: laforge <lafo...@osmocom.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-MessageType: merged