Attention is currently required from: laforge, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/libosmocore/+/36913?usp=email )
Change subject: add jhash.h, copied from linux/jhash.h ...................................................................... Patch Set 2: (1 comment) File include/osmocom/core/jhash.h: https://gerrit.osmocom.org/c/libosmocore/+/36913/comment/7a707006_fe4bf5b8 PS1, Line 100: c += osmo_load32le(k + 8); > ... i couldn't find it =) ... […] ah but load32le() is about always reading little endian, no matter what CPU, and get_unaligned_cpu32 is about always reading simply the CPU byte order, right? So osmo_get_unaligned_cpu32() is a legitimate addition and is not a dup of osmo_load32le(), correct? i guess then i'll indeed add the osmo_get_unaligned_cpu32()... -- To view, visit https://gerrit.osmocom.org/c/libosmocore/+/36913?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: libosmocore Gerrit-Branch: master Gerrit-Change-Id: I0c9652bbc9e2a18b1200e7d63bb6f64ded7d75fa Gerrit-Change-Number: 36913 Gerrit-PatchSet: 2 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Mon, 27 May 2024 13:52:21 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
