Attention is currently required from: osmith, pespin.

falconia has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-bts/+/36896?usp=email )

Change subject: common: add support for TW-TS-001
......................................................................


Patch Set 4:

(2 comments)

This change is ready for review.

File src/common/l1sap.c:

https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/67eaea98_9303058b
PS1, Line 1998:         uint8_t teh;
> Trau-like Extension Header, see the text of TW-TS-001 spec.
Done


File src/common/rtp_input_preen.c:

https://gerrit.osmocom.org/c/osmo-bts/+/36896/comment/64b03db5_b6a712a3
PS1, Line 104:          /* Strip TEH octet, leaving only standard EFR payload. 
*/
> Ack
Compilation builds are now passing thanks to libosmocore patches being merged, 
but Jenkins builder is still marking this patch as V-1 because of the linter 
tripping up on TEH. What do we do? Is there any kind of manual override? Or do 
we need to patch osmo-ci.git like @osm...@sysmocom.de originally suggested, and 
then maybe put that "teh||the" line back in after this osmo-bts patch is merged?



--
To view, visit https://gerrit.osmocom.org/c/osmo-bts/+/36896?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-bts
Gerrit-Branch: master
Gerrit-Change-Id: Id997e8666bc19e60936aaa83b43a968d30320bd7
Gerrit-Change-Number: 36896
Gerrit-PatchSet: 4
Gerrit-Owner: falconia <fal...@freecalypso.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-CC: osmith <osm...@sysmocom.de>
Gerrit-Attention: osmith <osm...@sysmocom.de>
Gerrit-Attention: pespin <pes...@sysmocom.de>
Gerrit-Comment-Date: Sat, 01 Jun 2024 00:37:54 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: osmith <osm...@sysmocom.de>
Comment-In-Reply-To: falconia <fal...@freecalypso.org>
Comment-In-Reply-To: pespin <pes...@sysmocom.de>
Gerrit-MessageType: comment

Reply via email to