Attention is currently required from: lynxis lazus, osmith.

laforge has posted comments on this change. ( 
https://gerrit.osmocom.org/c/pysim/+/36960?usp=email )

Change subject: esim.saip: Implement ProfileElement.header_name for more PE 
types
......................................................................


Patch Set 4:

(1 comment)

File pySim/esim/saip/__init__.py:

https://gerrit.osmocom.org/c/pysim/+/36960/comment/244cbbf6_d3f60983
PS3, Line 176:         elif self.type == 'genericFileManagement':
> you might use a dict for this. […]
Done



--
To view, visit https://gerrit.osmocom.org/c/pysim/+/36960?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: I37951a0441fe53fce7a329066aebd973389cb743
Gerrit-Change-Number: 36960
Gerrit-PatchSet: 4
Gerrit-Owner: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: lynxis lazus <lyn...@fe80.eu>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
Gerrit-Attention: osmith <osm...@sysmocom.de>
Gerrit-Attention: lynxis lazus <lyn...@fe80.eu>
Gerrit-Comment-Date: Tue, 04 Jun 2024 21:07:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: lynxis lazus <lyn...@fe80.eu>
Gerrit-MessageType: comment

Reply via email to