Patch Set 5: (1 comment)
https://gerrit.osmocom.org/#/c/5916/5/src/libbsc/chan_alloc.c File src/libbsc/chan_alloc.c: Line 80: for (j = 0; j < 8; j++) { > let's not use magic numbers but ARRAY_SIZE() here I actually considered changing jolly's patch here, but thought "nah, timeslots are 8, whatever" :) -- To view, visit https://gerrit.osmocom.org/5916 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: Ic8bee8a515ee8aa9a99af71756fe60b8dd8f868b Gerrit-PatchSet: 5 Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Owner: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Neels Hofmeyr <nhofm...@sysmocom.de> Gerrit-HasComments: Yes
