laforge has uploaded this change for review. ( 
https://gerrit.osmocom.org/c/pysim/+/37138?usp=email )


Change subject: pySim.cat: Add more alredy-defined IEs to ProactiveCmd classes
......................................................................

pySim.cat: Add more alredy-defined IEs to ProactiveCmd classes

... also add some spec references

Change-Id: If071abdc61c7c881bdea5292d12c74a1024f6784
---
M pySim/cat.py
1 file changed, 33 insertions(+), 8 deletions(-)



  git pull ssh://gerrit.osmocom.org:29418/pysim refs/changes/38/37138/1

diff --git a/pySim/cat.py b/pySim/cat.py
index bfd22b4..21a3cc8 100644
--- a/pySim/cat.py
+++ b/pySim/cat.py
@@ -482,7 +482,7 @@
 # TS 31.111 Section 8.56
 class ChannelStatus(COMPR_TLV_IE, tag = 0xB8):
     # complex decoding, depends on out-of-band context/knowledge :(
-    pass
+    _construct = HexAdapter(GreedyBytes)

 # TS 102 223 Section 8.58
 class OtherAddress(COMPR_TLV_IE, tag = 0xBE):
@@ -849,6 +849,7 @@
                             # TS 102 223 7.5.8 LanguageSelectionEvent
                             # TS 102 223 7.5.9 BrowserTerminationEvent
                             # TS 102 223 7.5.10 DataAvailableEvent
+                            ChannelStatus, ChannelDataLength,
                             # TS 102 223 7.5.11 ChannelStatusEvent
                             # TS 102 223 7.5.12 AccessTechnologyChangeEvent
                             # TS 102 223 7.5.13 DisplayParametersChangedEvent
@@ -925,20 +926,24 @@
                       ApplicationSpecificRefreshData, PlmnWactList, PlmnList]):
     pass
 
+# TS 102 223 Section 6.6.4
 class MoreTime(ProactiveCmd, tag=0x02,
-        nested=[CommandDetails]):
+        nested=[CommandDetails, DeviceIdentities]):
     pass

+# TS 102 223 Section 6.6.5
 class PollInterval(ProactiveCmd, tag=0x03,
-        nested=[CommandDetails]):
+        nested=[CommandDetails, DeviceIdentities, Duration]):
     pass

+# TS 102 223 Section 6.6.14
 class PollingOff(ProactiveCmd, tag=0x04,
-        nested=[CommandDetails]):
+        nested=[CommandDetails, DeviceIdentities]):
     pass

+# TS 102 223 Section 6.6.16
 class SetUpEventList(ProactiveCmd, tag=0x05,
-        nested=[CommandDetails]):
+        nested=[CommandDetails, DeviceIdentities, EventList]):
     pass

 # TS 31.111 Section 6.6.12
@@ -966,20 +971,27 @@
                                SMS_TPDU, IconIdentifier, TextAttribute, 
FrameIdentifier]):
     pass

+# TS 102 223 6.6.24
 class SendDTMF(ProactiveCmd, tag=0x14,
-        nested=[CommandDetails]):
+        nested=[CommandDetails, DeviceIdentities, AlphaIdentifier,
+                DtmfString, IconIdentifier, TextAttribute, FrameIdentifier]):
     pass

+# TS 102 223 6.6.26
 class LaunchBrowser(ProactiveCmd, tag=0x15,
-        nested=[CommandDetails]):
+        nested=[CommandDetails, DeviceIdentities, BrowserIdentity, Url, 
Bearer, ProvisioningFileReference,
+                TextString, AlphaIdentifer, IconIdentifier, TextAttribute, 
FrameIdentifier,
+                NetworkAccessName]):
     pass

 class GeographicalLocationRequest(ProactiveCmd, tag=0x16,
         nested=[CommandDetails]):
     pass

+# TS 102 223 6.6.5
 class PlayTone(ProactiveCmd, tag=0x20,
-        nested=[CommandDetails]):
+        nested=[CommandDetails, DeviceIdentities, AlphaIdentifier,
+                Tone, Duration, IconIdentifier, TextAttribute, 
FrameIdentifier]):
     pass

 # TS 101 220 Table 7.17 + 102 223 6.6.1/9.4 CMD=0x21
@@ -1215,6 +1227,8 @@
                        nested=[CommandDetails, DeviceIdentities, Result,
                                Duration, TextString, ItemIdentifier,
                                #TODO: LocalInformation and other 
optional/conditional IEs
+                               ChannelData, ChannelDataLength,
+                               ChannelStatus, BufferSize, BearerDescription,
                                ]):
     pass


--
To view, visit https://gerrit.osmocom.org/c/pysim/+/37138?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: pysim
Gerrit-Branch: master
Gerrit-Change-Id: If071abdc61c7c881bdea5292d12c74a1024f6784
Gerrit-Change-Number: 37138
Gerrit-PatchSet: 1
Gerrit-Owner: laforge <lafo...@osmocom.org>
Gerrit-MessageType: newchange

Reply via email to