Attention is currently required from: pespin. fixeria has posted comments on this change. ( https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email )
Change subject: mobile: cosmetic: fix -Wswitch in tch_voice_state_init() ...................................................................... Patch Set 1: (1 comment) File src/host/layer23/src/mobile/tch_voice.c: https://gerrit.osmocom.org/c/osmocom-bb/+/37212/comment/4878e0a4_7ec75460 PS1, Line 135: #endif > is this fine here? that makes it jump into TCH_VOICE_IOH_NONE. […] It's fine because we cannot end up having `state->handler == TCH_VOICE_IOH_GAPK` if built without `WITH_GAPK_IO`. The VTY does not permit that. So we treat this very unlikely to happen scenario the same way as `TCH_VOICE_IOH_NONE`. I don't see a need to add `/* fall through */` here because the pre-processor will produce the following code when building without `WITH_GAPK_IO`: ``` case TCH_VOICE_IOH_GAPK: case TCH_VOICE_IOH_NONE: rr->audio_mode = 0x00; break; ``` -- To view, visit https://gerrit.osmocom.org/c/osmocom-bb/+/37212?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Change-Id: I46afce396f730de26f21e0e4ec71e144aafd6beb Gerrit-Change-Number: 37212 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Comment-Date: Wed, 12 Jun 2024 12:39:56 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
