Attention is currently required from: fixeria, osmith, pespin. neels has posted comments on this change. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37189?usp=email )
Change subject: Osmocom_CTRL: counters: return -1 for absent objects ...................................................................... Patch Set 1: (1 comment) Patchset: PS1: > IMHO you are adding lots of complexity to regular APIs for a niche use case > which should probably be […] the reason why I like the implicit -1 is exactly because it is so simple and elegantly "docking" to current usage without interfering: A caller can test for a mix of absent and present counters, setting the expected-absent ones to -1, the expected-present ones to a value >= 0. The main visible feature of hnb_persistent is the counter, so why not use counter errors to indicate an absent object? Same for all other dynamic ctrgs in all our software. AFAICT this is the minimal possible patch to achieve this, seems to me your suggestion is the more complex one? We need others please to give opinions because it seems Pau and I will always disagree on this. Thanks! -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37189?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Id00bbfe721d453e5f551e6d47e1b1d03d219700b Gerrit-Change-Number: 37189 Gerrit-PatchSet: 1 Gerrit-Owner: neels <nhofm...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-CC: pespin <pes...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Sat, 15 Jun 2024 02:40:53 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de> Comment-In-Reply-To: pespin <pes...@sysmocom.de> Gerrit-MessageType: comment
