Attention is currently required from: neels.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-mgw/+/37280?usp=email )

Change subject: mgcp_test: test a=ptime:20, not 40
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

Commit Message:

https://gerrit.osmocom.org/c/osmo-mgw/+/37280/comment/bec0c277_4d293c1c
PS1, Line 11: never see anything else than 20 in practice
IIRC, 40 ms is the case for TCH/H (half rate channels).
But AFAICS, all definitions you're modifying are for TCH/F (like EFR), so it's 
fine.



--
To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/37280?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-mgw
Gerrit-Branch: master
Gerrit-Change-Id: Ia2292198bf6e3b72912afd69607654ca77fd549d
Gerrit-Change-Number: 37280
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Jun 2024 17:46:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to