Attention is currently required from: neels.

fixeria has posted comments on this change. ( 
https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37283?usp=email )

Change subject: mgw: add TC_crcx_iufp_sendrecv and _recvonly
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

File mgw/MGCP_Test.ttcn:

https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37283/comment/48e20faa_651b14ec
PS1, Line 2850: not ispresent(resp.sdp)
This is not needed, since `ispresent()` is safe against `foo.omit.bar`. `not 
ispresent(resp.sdp.connection)` alone would do the job, but this is not 
critical and can be kept like that.



--
To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/37283?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings

Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Change-Id: I00fd854f058f7f53e2f579e8481ca2b9253f08e3
Gerrit-Change-Number: 37283
Gerrit-PatchSet: 1
Gerrit-Owner: neels <nhofm...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Attention: neels <nhofm...@sysmocom.de>
Gerrit-Comment-Date: Mon, 24 Jun 2024 20:04:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment

Reply via email to