dexter has submitted this change. (
https://gerrit.osmocom.org/c/osmo-pcu/+/37550?usp=email )
Change subject: fix E1 TS output when used with osmo-e1d
......................................................................
fix E1 TS output when used with osmo-e1d
The original code did E1 raw TS output by posting directly to
&ts->raw.tx_queue instead of calling e1inp_ts_send_raw();
doing so bypasses the call to driver->want_write performed in
e1inp layer. This approach worked for DAHDI where no
select-for-write is used; however, e1inp interface to osmo-e1d
does use select-for-write, hence applications like osmo-mgw
do need to use e1inp_ts_send_raw() API in order to work
correctly.
Change-Id: Ia2e0fa27195fc1ae75e441038eb4adeb4cf1d6cf
---
M src/ericsson-rbs/er_ccu_if.c
1 file changed, 19 insertions(+), 1 deletion(-)
Approvals:
pespin: Looks good to me, but someone else must approve
Jenkins Builder: Verified
laforge: Looks good to me, approved
falconia: Looks good to me, but someone else must approve
diff --git a/src/ericsson-rbs/er_ccu_if.c b/src/ericsson-rbs/er_ccu_if.c
index 98abbf7..ad7f353 100644
--- a/src/ericsson-rbs/er_ccu_if.c
+++ b/src/ericsson-rbs/er_ccu_if.c
@@ -126,7 +126,7 @@
DEBUG_BYTES_MAX ?
DEBUG_BYTES_MAX : msgb_length(msg)));
/* Hand data over to the E1 stack */
- msgb_enqueue(&ts->raw.tx_queue, msg);
+ e1inp_ts_send_raw(ts, msg);
}
/* Callback function to handle incoming E1 traffic */
--
To view, visit https://gerrit.osmocom.org/c/osmo-pcu/+/37550?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings
Gerrit-Project: osmo-pcu
Gerrit-Branch: master
Gerrit-Change-Id: Ia2e0fa27195fc1ae75e441038eb4adeb4cf1d6cf
Gerrit-Change-Number: 37550
Gerrit-PatchSet: 2
Gerrit-Owner: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: dexter <pma...@sysmocom.de>
Gerrit-Reviewer: falconia <fal...@freecalypso.org>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: pespin <pes...@sysmocom.de>
Gerrit-MessageType: merged
