Attention is currently required from: Hoernchen, pespin.

laforge has posted comments on this change by laforge. ( 
https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email )

Change subject: core/socket.c: Fix socket binding on IPv4-only hosts
......................................................................


Patch Set 3:

(2 comments)

Commit Message:

https://gerrit.osmocom.org/c/libosmocore/+/37874/comment/3f1ed475_80e3e1f4?usp=email
 :
PS1, Line 19: > valid as a configured address.  *This flag is useful  on,  for  
example,
> Then maybe worth it testing what I mentioned about running getaddrinfo twice 
> if first with flag fail […]
I chose to go down a different route altogether, comment no longer relevant.


File src/core/socket.c:

https://gerrit.osmocom.org/c/libosmocore/+/37874/comment/e21066bc_91e08f0d?usp=email
 :
PS1, Line 85:   rc = getaddrinfo(host, portbuf, &hints, &result);
> That might be an option. […]
I chose to go down a different route altogether, comment no longer relevant.



--
To view, visit https://gerrit.osmocom.org/c/libosmocore/+/37874?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: libosmocore
Gerrit-Branch: master
Gerrit-Change-Id: I5690a25af98089e3a8a092cb91dfc969720abdc0
Gerrit-Change-Number: 37874
Gerrit-PatchSet: 3
Gerrit-Owner: laforge <[email protected]>
Gerrit-Reviewer: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: Hoernchen <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Tue, 20 Aug 2024 14:59:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to