Attention is currently required from: daniel, pespin. Jenkins Builder has posted comments on this change by lynxis lazus. ( https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email )
Change subject: add routing areas ...................................................................... Patch Set 3: (11 comments) File include/osmocom/sgsn/gprs_routing_area.h: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/b7a6fce6_3ce3e22b?usp=email : PS3, Line 70: int sgsn_ra_foreach_cell(struct sgsn_ra *ra, sgsn_ra_cb_t *cb, void *cb_data); space required before the open parenthesis '(' File src/sgsn/gprs_routing_area.c: Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/9f343d45_b6a88a1d?usp=email : PS3, Line 30: llist_for_each_entry_safe(cell, cell2, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/ebfd19c6_e08cf349?usp=email : PS3, Line 95: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/ad3310bb_7d6bb7eb?usp=email : PS3, Line 111: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/be8652bf_fd79f736?usp=email : PS3, Line 112: llist_for_each_entry(cell, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/9995ba96_2f6c02a2?usp=email : PS3, Line 124: int sgsn_ra_foreach_cell(struct sgsn_ra *ra, sgsn_ra_cb_t *cb, void *cb_data) space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/ef67dd7b_9be6dbfe?usp=email : PS3, Line 131: llist_for_each_entry_safe(cell, tmp, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/f4de5dbe_845d7de9?usp=email : PS3, Line 157: return sgsn_ra_foreach_cell(ra, cb, cb_data); space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/523d30f4_108024e5?usp=email : PS3, Line 164: llist_for_each_entry(cell, &ra->cells, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/b39c5e74_e474e33b?usp=email : PS3, Line 179: llist_for_each_entry(ra, &sgsn_ra_ctx->ras, list) { space required before the open parenthesis '(' Robot Comment from checkpatch (run ID jenkins-gerrit-lint-17907): https://gerrit.osmocom.org/c/osmo-sgsn/+/37864/comment/dc254e1a_2c19c0a6?usp=email : PS3, Line 183: llist_for_each_entry(cell, &ra->cells, list) { space required before the open parenthesis '(' -- To view, visit https://gerrit.osmocom.org/c/osmo-sgsn/+/37864?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-sgsn Gerrit-Branch: master Gerrit-Change-Id: I2474b19a7471a1dea3c863ddf8372b16180211aa Gerrit-Change-Number: 37864 Gerrit-PatchSet: 3 Gerrit-Owner: lynxis lazus <[email protected]> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <[email protected]> Gerrit-Reviewer: pespin <[email protected]> Gerrit-Attention: pespin <[email protected]> Gerrit-Attention: daniel <[email protected]> Gerrit-Comment-Date: Tue, 20 Aug 2024 15:18:51 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No
