Attention is currently required from: fixeria. pespin has posted comments on this change by fixeria. ( https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38099?usp=email )
Change subject: s1gw: move t_ConnHdlrPars back to S1GW_Tests ...................................................................... Patch Set 1: Code-Review+2 (1 comment) File s1gw/S1GW_Tests.ttcn: https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38099/comment/68638a6c_42595636?usp=email : PS1, Line 168: var ConnHdlrPars pars := valueof(t_ConnHdlrPars); I really don't see why you prefer having a valueof(t_ConnHdlrPars) instead of an already in place function which can be extended later on, but I won't bother discussing. -- To view, visit https://gerrit.osmocom.org/c/osmo-ttcn3-hacks/+/38099?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-ttcn3-hacks Gerrit-Branch: master Gerrit-Change-Id: Ibc34d0219a616a239c0595e61a783f18fbc91b36 Gerrit-Change-Number: 38099 Gerrit-PatchSet: 1 Gerrit-Owner: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: pespin <pes...@sysmocom.de> Gerrit-Attention: fixeria <vyanits...@sysmocom.de> Gerrit-Comment-Date: Thu, 12 Sep 2024 12:36:40 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes