laforge has submitted this change. ( https://gerrit.osmocom.org/c/pysim/+/38001?usp=email )
Change subject: pySim-shell: print cardinfo hexstrings in lowercase ...................................................................... pySim-shell: print cardinfo hexstrings in lowercase To ensure consistency, let's print the cardinfo hexstrings in lowercase only. Related: OS#6531 Change-Id: Ia6a8bd0e700c7fd933fb6c1b1050ed9494462d60 --- M pySim-shell.py 1 file changed, 6 insertions(+), 6 deletions(-) Approvals: fixeria: Looks good to me, approved laforge: Looks good to me, but someone else must approve Jenkins Builder: Verified diff --git a/pySim-shell.py b/pySim-shell.py index 4f168d8..7db77f0 100755 --- a/pySim-shell.py +++ b/pySim-shell.py @@ -818,17 +818,17 @@ """Display information about the currently inserted card""" self._cmd.poutput("Card info:") self._cmd.poutput(" Name: %s" % self._cmd.card.name) - self._cmd.poutput(" ATR: %s" % self._cmd.rs.identity['ATR']) + self._cmd.poutput(" ATR: %s" % self._cmd.rs.identity['ATR'].lower()) eid = self._cmd.rs.identity.get('EID', None) if eid: - self._cmd.poutput(" EID: %s" % eid) - self._cmd.poutput(" ICCID: %s" % self._cmd.rs.identity['ICCID']) - self._cmd.poutput(" Class-Byte: %s" % self._cmd.lchan.scc.cla_byte) - self._cmd.poutput(" Select-Ctrl: %s" % self._cmd.lchan.scc.sel_ctrl) + self._cmd.poutput(" EID: %s" % eid.lower()) + self._cmd.poutput(" ICCID: %s" % self._cmd.rs.identity['ICCID'].lower()) + self._cmd.poutput(" Class-Byte: %s" % self._cmd.lchan.scc.cla_byte.lower()) + self._cmd.poutput(" Select-Ctrl: %s" % self._cmd.lchan.scc.sel_ctrl.lower()) if len(self._cmd.rs.mf.applications) > 0: self._cmd.poutput(" AIDs:") for a in self._cmd.rs.mf.applications: - self._cmd.poutput(" %s" % a) + self._cmd.poutput(" %s" % a.lower()) @with_default_category('ISO7816 Commands') class Iso7816Commands(CommandSet): -- To view, visit https://gerrit.osmocom.org/c/pysim/+/38001?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: merged Gerrit-Project: pysim Gerrit-Branch: master Gerrit-Change-Id: Ia6a8bd0e700c7fd933fb6c1b1050ed9494462d60 Gerrit-Change-Number: 38001 Gerrit-PatchSet: 5 Gerrit-Owner: dexter <pma...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org>