fixeria has submitted this change. (
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38141?usp=email )
Change subject: s1ap_proxy: fix E-RAB FSM lookup for RELEASE related IEs
......................................................................
s1ap_proxy: fix E-RAB FSM lookup for RELEASE related IEs
We use a tuple of {MmeUeId, EnbUeId, RABId} to register and lookup
E-RAB FSMs in the registry. Using RABId alone is wrong (because
it's not a globally unique ID) and will never yield anything.
Because of this bug the E-RAB FSMs were never terminated properly.
This was found thanks to the ttcn3-s1gw-test and remained unnoticed
so far because in test_e_rab_release() we still have this TODO:
%% TODO: make sure that the E-RAB FSM has been terminated
We'll need to add some E-RAB introspection API to implement this.
Change-Id: Ic737e7b0c08562ecfd641ce4e3c2f27c26f8560e
Fixes: 935a0f02 "{sctp,s1ap}_proxy: employ E-RAB FSMs"
---
M src/s1ap_proxy.erl
1 file changed, 2 insertions(+), 2 deletions(-)
Approvals:
Jenkins Builder: Verified
osmith: Looks good to me, approved
laforge: Looks good to me, but someone else must approve
diff --git a/src/s1ap_proxy.erl b/src/s1ap_proxy.erl
index f28ff56..1df1518 100644
--- a/src/s1ap_proxy.erl
+++ b/src/s1ap_proxy.erl
@@ -269,7 +269,7 @@
value = Content}, S) ->
%% poke E-RAB FSM
#'E-RABItem'{'e-RAB-ID' = ERABId} = Content,
- case dict:find(ERABId, S#proxy_state.erabs) of
+ case erab_fsm_find(ERABId, S) of
{ok, Pid} ->
ok = erab_fsm:erab_release_req(Pid);
error ->
@@ -287,7 +287,7 @@
value = Content}, S) ->
%% poke E-RAB FSM
#'E-RABReleaseItemBearerRelComp'{'e-RAB-ID' = ERABId} = Content,
- case dict:find(ERABId, S#proxy_state.erabs) of
+ case erab_fsm_find(ERABId, S) of
{ok, Pid} ->
ok = erab_fsm:erab_release_rsp(Pid);
error ->
--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/38141?usp=email
To unsubscribe, or for help writing mail filters, visit
https://gerrit.osmocom.org/settings?usp=email
Gerrit-MessageType: merged
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ic737e7b0c08562ecfd641ce4e3c2f27c26f8560e
Gerrit-Change-Number: 38141
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de>
Gerrit-Reviewer: laforge <lafo...@osmocom.org>
Gerrit-Reviewer: osmith <osm...@sysmocom.de>
