Attention is currently required from: daniel, laforge, osmith, pespin. fixeria has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-bsc/+/39003?usp=email )
Change subject: ipaccess-config: Use own e1_input ipaccess driver ...................................................................... Patch Set 3: Code-Review+1 (1 comment) File src/ipaccess/ipaccess-config-e1-driver.c: https://gerrit.osmocom.org/c/osmo-bsc/+/39003/comment/d688d2f1_47b6d494?usp=email : PS3, Line 539: e1inp_ipaccess_config_set_connect_addr Can we just use `osmo_talloc_replace_string()` here? ``` osmo_talloc_replace_string(tall_ipa_ctx, &g_e1inp_ipaccess_config_pars.connect_addr, connect_addr); ``` -- To view, visit https://gerrit.osmocom.org/c/osmo-bsc/+/39003?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-bsc Gerrit-Branch: master Gerrit-Change-Id: I4d26876ce7d75a78f03c4fa66233550baf4fa7d5 Gerrit-Change-Number: 39003 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: fixeria <vyanits...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-Reviewer: osmith <osm...@sysmocom.de> Gerrit-Attention: osmith <osm...@sysmocom.de> Gerrit-Attention: laforge <lafo...@osmocom.org> Gerrit-Attention: pespin <pes...@sysmocom.de> Gerrit-Attention: daniel <dwillm...@sysmocom.de> Gerrit-Comment-Date: Mon, 02 Dec 2024 20:01:06 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes
