Harald Welte has submitted this change and it was merged.
Change subject: bsc: Fix TC_chan_act_ack_est_ind_noreply()
......................................................................
bsc: Fix TC_chan_act_ack_est_ind_noreply()
This test case was incomplete in that it
* applied the wrong timeout T3101 instead of T3210
* didn't account for a RLL REL REQ/RESP before RF_CHAN_REL
Let's fix it. Together with OsmoBSC Change-Id
Ie11d7d06353ba1b1e2fab6763dd7b032ce8a5d2c this check now actually
passes for the first time.
Change-Id: I9ed41d246cf153735fd4e71cc6cc174ede32a76b
---
M bsc/BSC_Tests.ttcn
1 file changed, 12 insertions(+), 1 deletion(-)
Approvals:
Harald Welte: Looks good to me, approved
Jenkins Builder: Verified
diff --git a/bsc/BSC_Tests.ttcn b/bsc/BSC_Tests.ttcn
index c7b5a8f..b65d899 100644
--- a/bsc/BSC_Tests.ttcn
+++ b/bsc/BSC_Tests.ttcn
@@ -308,7 +308,10 @@
/* Test behavior if MSC never answers to CR */
testcase TC_chan_act_ack_est_ind_noreply() runs on test_CT {
+ var RslLinkId main_dcch := valueof(ts_RslLinkID_DCCH(0));
+ var IpaStreamId sid := IPAC_PROTO_RSL_TRX0;
var RSL_Message rx_rsl;
+ var ASP_RSL_Unitdata rx_rsl_ud;
f_init(1);
f_bssap_reset();
@@ -322,7 +325,15 @@
BSSAP.receive(tr_BSSAP_CONNECT_ind(?, ?, tr_BSSMAP_ComplL3(l3)));
/* expect BSC to disable the channel again if there's no response from
MSC */
- rx_rsl := f_exp_ipa_rx(0, tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL),
T3101_MAX);
+ /* MS waits 20s (T3210) at LU; 10s (T3230) at CM SERV REQ and 5s
(T3220) AT detach */
+ IPA_RSL[0].clear;
+ alt {
+ [] IPA_RSL[0].receive(tr_ASP_RSL_UD(sid,
tr_RSL_MsgTypeD(RSL_MT_RF_CHAN_REL))) -> value rx_rsl_ud { }
+ [] IPA_RSL[0].receive(tr_ASP_RSL_UD(sid, tr_RSL_REL_REQ(chan_nr, ?)))
-> value rx_rsl_ud {
+ f_ipa_tx(0, ts_RSL_REL_CONF(chan_nr, main_dcch));
+ repeat;
+ }
+ }
setverdict(pass);
}
--
To view, visit https://gerrit.osmocom.org/6174
To unsubscribe, visit https://gerrit.osmocom.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: I9ed41d246cf153735fd4e71cc6cc174ede32a76b
Gerrit-PatchSet: 2
Gerrit-Project: osmo-ttcn3-hacks
Gerrit-Branch: master
Gerrit-Owner: Harald Welte <[email protected]>
Gerrit-Reviewer: Harald Welte <[email protected]>
Gerrit-Reviewer: Jenkins Builder
