Attention is currently required from: neels. pespin has posted comments on this change by pespin. ( https://gerrit.osmocom.org/c/osmo-mgw/+/39248?usp=email )
Change subject: mgw: Decouple SDP parsing step from conn obj update ...................................................................... Patch Set 3: (3 comments) File include/osmocom/mgcp/mgcp_protocol.h: https://gerrit.osmocom.org/c/osmo-mgw/+/39248/comment/30f2ff15_0ee7efcd?usp=email : PS3, Line 13: #define MGCP_PARSE_SDP_MAXPTIME_UNSET (-1) > duplicate -1 It's not duplicate, it's two different fields. https://gerrit.osmocom.org/c/osmo-mgw/+/39248/comment/8c2af996_f6210744?usp=email : PS3, Line 14: #define MGCP_PARSE_SDP_RTP_PORT_UNSET (0) > (i prefer enums) It's not a closed set of values, but a specific value in an int range, it's fine as a define. File src/libosmo-mgcp/mgcp_protocol.c: https://gerrit.osmocom.org/c/osmo-mgw/+/39248/comment/025b22e4_0b6d85b1?usp=email : PS3, Line 1139: if (rc < 0) { /* See also RFC 3661: Protocol error */ > (comments deserve their own separate line plz) I'm actually fine with it the current way, but changing in to avoid discussions. -- To view, visit https://gerrit.osmocom.org/c/osmo-mgw/+/39248?usp=email To unsubscribe, or for help writing mail filters, visit https://gerrit.osmocom.org/settings?usp=email Gerrit-MessageType: comment Gerrit-Project: osmo-mgw Gerrit-Branch: master Gerrit-Change-Id: I4a2aecb542886672c1f586c6607714e0356abe35 Gerrit-Change-Number: 39248 Gerrit-PatchSet: 3 Gerrit-Owner: pespin <pes...@sysmocom.de> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: daniel <dwillm...@sysmocom.de> Gerrit-Reviewer: laforge <lafo...@osmocom.org> Gerrit-CC: neels <nhofm...@sysmocom.de> Gerrit-Attention: neels <nhofm...@sysmocom.de> Gerrit-Comment-Date: Wed, 15 Jan 2025 17:36:02 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: No Comment-In-Reply-To: neels <nhofm...@sysmocom.de>
