Attention is currently required from: laforge.

Hoernchen has posted comments on this change by Hoernchen. ( 
https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39441?usp=email )

Change subject: tame the linter
......................................................................


Patch Set 1:

(1 comment)

Patchset:

PS1:
> do we really want all of that for the entire code base?  Shouldn't this 
> relaxed linker (like trailin […]
The linter understands code as much as grep and randomly tries to lint 
everything including linker scripts and nested funcs with defines and inline 
asm and breaks all the time and i'd rather add a .clang-format and that's it. 
There is no real split between imported and own code since the asf code needs 
occasional changes, too. There is not even a reasonable directory structure 
with asf placing the start code and linker scripts two dirs deep. Changing that 
means it can't easily compared to other half generated code (....)



--
To view, visit https://gerrit.osmocom.org/c/osmo-ccid-firmware/+/39441?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: osmo-ccid-firmware
Gerrit-Branch: master
Gerrit-Change-Id: I84f8637b47047bb9b8c217b0869a486ceee7243f
Gerrit-Change-Number: 39441
Gerrit-PatchSet: 1
Gerrit-Owner: Hoernchen <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-CC: laforge <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Comment-Date: Thu, 30 Jan 2025 13:06:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: laforge <[email protected]>

Reply via email to