Attention is currently required from: laforge, osmith, pespin.

fixeria has posted comments on this change by fixeria. ( 
https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39463?usp=email )

Change subject: s1ap_proxy: handle UE CONTEXT RELEASE PDUs
......................................................................


Patch Set 1:

(1 comment)

File include/s1gw_metrics.hrl:

https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39463/comment/048c1b47_23474c8f?usp=email
 :
PS1, Line 29: -define(S1GW_CTR_S1AP_PROXY_IN_PKT_RELEASE_CTX_COMPL, [ctr, s1ap, 
proxy, in_pkt, release_ctx_cnf]).
> RELEASE_CTX_COMPL vs release_ctx_cnf in the same line?
Good catch, it should indeed be `release_ctx_compl`. Thanks!



--
To view, visit https://gerrit.osmocom.org/c/erlang/osmo-s1gw/+/39463?usp=email
To unsubscribe, or for help writing mail filters, visit 
https://gerrit.osmocom.org/settings?usp=email

Gerrit-MessageType: comment
Gerrit-Project: erlang/osmo-s1gw
Gerrit-Branch: master
Gerrit-Change-Id: Ic94489e3d3052221b49431da3a95e5c1eb0e0ba0
Gerrit-Change-Number: 39463
Gerrit-PatchSet: 1
Gerrit-Owner: fixeria <[email protected]>
Gerrit-Reviewer: Jenkins Builder
Gerrit-Reviewer: laforge <[email protected]>
Gerrit-Reviewer: osmith <[email protected]>
Gerrit-Reviewer: pespin <[email protected]>
Gerrit-Attention: osmith <[email protected]>
Gerrit-Attention: laforge <[email protected]>
Gerrit-Attention: pespin <[email protected]>
Gerrit-Comment-Date: Fri, 07 Feb 2025 12:38:36 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: pespin <[email protected]>

Reply via email to