Patch Set 5: Code-Review-1 (1 comment)
> I'll leave it up to vadim. Once vadim is happy, let me know for > some final review and hopefully +2 I'll rewrite the code to use libosmocoding, because I have some experience with it and don't want to see the code duplication. The main idea is to use gsm0503_pdtch_egprs_(de|en)code like OsmoBTS does. This is what libosmocoding is intended for ;) https://gerrit.osmocom.org/#/c/5992/5/src/host/gprsdecode/Makefile.am File src/host/gprsdecode/Makefile.am: Line 2: AM_CFLAGS = -Wall -O3 -pipe -flto -std=gnu99 -g $(LIBOSMOCORE_CFLAGS) $(LIBOSMOGSM_CFLAGS) $(LIBOSMOCODING_CFLAGS) ws -- To view, visit https://gerrit.osmocom.org/5992 To unsubscribe, visit https://gerrit.osmocom.org/settings Gerrit-MessageType: comment Gerrit-Change-Id: I12234d37c66b83b8abd60f7511fa1d7837db1856 Gerrit-PatchSet: 5 Gerrit-Project: osmocom-bb Gerrit-Branch: master Gerrit-Owner: Max <msur...@sysmocom.de> Gerrit-Reviewer: Harald Welte <lafo...@gnumonks.org> Gerrit-Reviewer: Jenkins Builder Gerrit-Reviewer: Max <msur...@sysmocom.de> Gerrit-Reviewer: Vadim Yanitskiy <axilira...@gmail.com> Gerrit-Reviewer: fixeria <axilira...@gmail.com> Gerrit-HasComments: Yes
